fossasia / meilix-generator

WebApp for generating a custom ISO image based on Meilix http://meilix.org
GNU Lesser General Public License v3.0
1.53k stars 113 forks source link

Nosetests should not be used in travis #116

Open ParthS007 opened 6 years ago

ParthS007 commented 6 years ago

I'm submitting a ... (check one with "x")

Actual Behaviour Presently, Travis run script nosetests app.py while testing which is not needed as nose is used for testing unit tests and moreover nose collects tests from unittest.TestCase subclasses or we can also write simple test functions, as well as test classes that are not subclasses of unittest.TestCase. But there are no such tests in app.py so the command nosetests app.py is executed with ok status always irrespective of the changes done in the Pull Request.

Expected Behaviour We should add tests which test functions present in app.py which will be tested in Travis.

Steps to reproduce it

Please see Travis logs for any PR. Like here image

Would you like to work on the issue? Yes

@mariobehling @meets2tarun @xeon-zolt Please give your views

meets2tarun commented 6 years ago

Thanks @ParthS007 Go for solving the issue.

tabesin commented 5 years ago

What is the status of this item?

pranav1698 commented 5 years ago

What tests we need to run for this issue? We cannot run test for the index function because it requires a live HTTP request and which will make the travis build fail