fossasia / meilix-generator

WebApp for generating a custom ISO image based on Meilix http://meilix.org
GNU Lesser General Public License v3.0
1.53k stars 112 forks source link

Strategy for setting wallpaper as the background #17

Closed meets2tarun closed 6 years ago

meets2tarun commented 7 years ago

There will be a upload button on the webapp where the user can upload their wallpaper which he wants to set it as the default background on the desktop of the iso build. Ideas to implement this?

xeon-zolt commented 7 years ago

already built file by using it here

https://github.com/xeon-zolt/meilix/blob/master/build.sh#L27-L28

and my doubt is do we need to keep the file name same or can it ve different from wallpaper

plan

in this plan the name of the file should always be same so the link always remain same and when user uploads it the previous image will be replaced and this will be downloaded in the travis where image for wallpaper is required

abishekvashok commented 7 years ago

IMO, don't make a github release for each build, you can mail directly from Travis.

meets2tarun commented 7 years ago

@abishekvashok Why do you think that it's not better to make a Github release of each build?

meets2tarun commented 7 years ago

If I change the wallpaper on this location https://github.com/fossasia/meilix/tree/master/meilix-default-settings/usr/share/meilix/images Question is:

abishekvashok commented 7 years ago

Filename matters as well

meets2tarun commented 7 years ago

Filename is xp_default_wallpaper which is not good at all. Is there a way to change it and get the picture under that location as the wallpaper?

abishekvashok commented 7 years ago

Well see build.sh

xeon-zolt commented 7 years ago

@abishekvashok nothing related to wallpaper name in build.sh

niccokunzmann commented 7 years ago

looks good to me. I think, this can work.

niccokunzmann commented 7 years ago

Also an idea: grafik

  1. Heroku creates a tag using the api
  2. The travis build knows its tag and downloads the config
  3. as was before

using tags means that you can know the iso name before the build starts.

This option just came to my mind and I wanted to throw it into the discussion.

xeon-zolt commented 7 years ago

deployed a test app with wallpaper upload and initiate build https://meilix-generator-test.herokuapp.com/ and after upload the wallpaper link is https://meilix-generator-test.herokuapp.com/uploads/wallpaper

xeon-zolt commented 7 years ago

now 2 things for this

do wallpaper in meilix dependent on name xp_default_wallpaper and are we gonna change the master branch of meilix or create a new branch as build.sh required to be edited a new branch is better idea according to me

meets2tarun commented 7 years ago

deployed a test app with wallpaper upload and initiate build

Question: This will send the uploaded wallpaper to this location with the name of the wallpaper uploaded https://github.com/fossasia/meilix/tree/master/meilix-default-settings/usr/share/meilix/images

meets2tarun commented 7 years ago

and are we gonna change the master branch of meilix or create a new branch as build.sh required to be edited

for testing purpose, we can first test in forked repo then will think to go for a new branch (may be).

xeon-zolt commented 7 years ago

deployed a test app with wallpaper upload and initiate build

Question: This will send the uploaded wallpaper to this location with the name of the wallpaper uploaded https://github.com/fossasia/meilix/tree/master/meilix-default-settings/usr/share/meilix/images

yes it will upload image here with the name wallpaper

for testing purpose, we can first test in forked repo then will think to go for a new branch (may be).

can you tell me about wallpaper name question after test already doing it in forked repo

meets2tarun commented 7 years ago

We are almost done with the implementation, just remaining is to test it after an install or live boot.

abishekvashok commented 7 years ago

Updates

rpotter12 commented 6 years ago

@abishekvashok @meets2tarun I think this issue is done. Please check this once.