Closed meets2tarun closed 6 years ago
already built file by using it here
https://github.com/xeon-zolt/meilix/blob/master/build.sh#L27-L28
and my doubt is do we need to keep the file name same or can it ve different from wallpaper
in this plan the name of the file should always be same so the link always remain same and when user uploads it the previous image will be replaced and this will be downloaded in the travis where image for wallpaper is required
IMO, don't make a github release for each build, you can mail directly from Travis.
@abishekvashok Why do you think that it's not better to make a Github release of each build?
If I change the wallpaper on this location https://github.com/fossasia/meilix/tree/master/meilix-default-settings/usr/share/meilix/images Question is:
Filename matters as well
Filename is xp_default_wallpaper
which is not good at all.
Is there a way to change it and get the picture under that location as the wallpaper?
Well see build.sh
@abishekvashok nothing related to wallpaper name in build.sh
looks good to me. I think, this can work.
Also an idea:
using tags means that you can know the iso name before the build starts.
This option just came to my mind and I wanted to throw it into the discussion.
deployed a test app with wallpaper upload and initiate build https://meilix-generator-test.herokuapp.com/ and after upload the wallpaper link is https://meilix-generator-test.herokuapp.com/uploads/wallpaper
do wallpaper in meilix dependent on name xp_default_wallpaper and are we gonna change the master branch of meilix or create a new branch as build.sh required to be edited a new branch is better idea according to me
deployed a test app with wallpaper upload and initiate build
Question: This will send the uploaded wallpaper to this location with the name of the wallpaper uploaded https://github.com/fossasia/meilix/tree/master/meilix-default-settings/usr/share/meilix/images
and are we gonna change the master branch of meilix or create a new branch as build.sh required to be edited
for testing purpose, we can first test in forked repo then will think to go for a new branch (may be).
deployed a test app with wallpaper upload and initiate build
Question: This will send the uploaded wallpaper to this location with the name of the wallpaper uploaded https://github.com/fossasia/meilix/tree/master/meilix-default-settings/usr/share/meilix/images
yes it will upload image here with the name wallpaper
for testing purpose, we can first test in forked repo then will think to go for a new branch (may be).
can you tell me about wallpaper name question after test already doing it in forked repo
We are almost done with the implementation, just remaining is to test it after an install or live boot.
Updates
@abishekvashok @meets2tarun I think this issue is done. Please check this once.
There will be a upload button on the webapp where the user can upload their wallpaper which he wants to set it as the default background on the desktop of the iso build. Ideas to implement this?