search

fossasia / meilix-generator

WebApp for generating a custom ISO image based on Meilix http://meilix.org
GNU Lesser General Public License v3.0
1.53k stars 112 forks source link

MVC compliance refactoring #1 - Inline Style to external CSS #252

Closed tabesin closed 6 years ago

tabesin commented 6 years ago

I'm submitting a ... (check one with "x")

Task The code of html templates needs to be checked if it adheres to MVC separation principles.https://en.wikipedia.org/wiki/Model%E2%80%93view%E2%80%93controller

First task #1 is to review the html template code so that all "style tags" are moved from the html into CSS declarations.

That is to convert all inline CSS to external CSS. Do this manually or with the help of tools like http://extractcss.com/ or see https://stackoverflow.com/questions/26205640/how-to-convert-inline-css-into-external-css

If no such inline CSS exist (anymore) this ticket will be closed.

pranav1698 commented 6 years ago

Hey @tabesin, Starting to work on this issue

championpaddler commented 6 years ago

@tabesin I have will fix this in my next pr.

pranav1698 commented 6 years ago

@sk9331657 I have already started to work on this issue You can work on other issues

championpaddler commented 6 years ago

@pranav1698 This issue was created from https://github.com/fossasia/meilix-generator/pull/251 which was submitted by me as @tabesin told about opening different else this was to be solved in that pr.

pranav1698 commented 6 years ago

That was another pr This is a new issue, and I have commented on it first Please work on any other You will get plenty of them

On Sat, Oct 6, 2018, 18:36 SHUBHAM KUMAR notifications@github.com wrote:

@pranav1698 https://github.com/pranav1698 This issue was created from

251 https://github.com/fossasia/meilix-generator/pull/251 which was

submitted by me as @tabesin https://github.com/tabesin told about opening different else this was to be solved in that pr.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fossasia/meilix-generator/issues/252#issuecomment-427572291, or mute the thread https://github.com/notifications/unsubscribe-auth/AhJO2QOQM80LdjYNPO8042gZn1m0LEAQks5uiKregaJpZM4XLTt- .