Closed pranav1698 closed 6 years ago
GIF for present changes:
@pranav1698 Flask code also need to be edited to get the image
@xeon-zolt There is nothing happening on clicking the build button,(after filling the details)
will I have to add a new filename for this logo section like in wallpapers
we need to store logo like we did for wallpaper then we need to tweak meilix for using that logo in for example plymouth for this issue it should be uploaded and stored on the server
What does logo mean other than wallpaper?
We should not have plymouth custom teaming for now as it is quite complicated.
@tabesin @xeon-zolt what do I need to do for now for the pr
@pranav1698 What is the need of the logo here? How it will be beneficial to the user?
Hey @meets2tarun, I made this pr in respnse to issue #107 What i understood was that the logo will be the image of the default logo for the iso like the default wallpaper If I misunderstood please clear??
ok @pranav1698 Please clear the conflicts and work on the portion that Harsh has mentioned in the top comment.
Ok @meets2tarun, On it
On Mon, Oct 15, 2018, 14:39 Tarun Kumar notifications@github.com wrote:
ok @pranav1698 https://github.com/pranav1698 Please clear the conflicts and work on the portion that Harsh has mentioned in the top comment.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fossasia/meilix-generator/pull/272#issuecomment-429766389, or mute the thread https://github.com/notifications/unsubscribe-auth/AhJO2XqyTFbAE16YPwd06FBybKoARrHoks5ulFDggaJpZM4XVFgj .
Sorry for the extra commits I was trying to squash my commits and something unexpected happen I have squashed before but never recieved such results
@pranav1698 I feel you brother. Same happens with me. Squashing sometimes produces terrible results!!
Hi @pranav1698!
It looks like one or more of your builds have failed. I've added the relevant info below to save you some time.
failed
I am opening a new pr beacause of lots of complexities
Checklist
master
branch.Short description of what this resolves:
This adds a option(similar to wallpaper) to upload a vector logo for the desktop to the user
Changes proposed in this pull request:
-Adding an upload logo button similar upload wallpaper option
-
Fixes #107