fossasia / meilix-generator

WebApp for generating a custom ISO image based on Meilix http://meilix.org
GNU Lesser General Public License v3.0
1.53k stars 113 forks source link

fixes #269 and #249 (template for build.html and DRY template reorgan… #289

Closed sarnava1 closed 5 years ago

sarnava1 commented 5 years ago

…isation)

Checklist

Short description of what this resolves:

This PR gives the template for build.html which goes with the UI of the main page and also introduces DRY template reorganisation. Navbar and footer are there in the includes folder and we have a general layout for the pages.

Fixes #266 and #249

sarnava1 commented 5 years ago

@tabesin and @meets2tarun these were the major changes which were required and which was raised by @tabesin in issues #249 and #266. I think the PR satisfies all the requirements. Please review my PR.

meets2tarun commented 5 years ago

@sarnava1 you must provide some screenshot or link to your Heroku deployment for cross checking purpose. Please take care of these in the future.

sarnava1 commented 5 years ago

@meets2tarun sure. I will remember this in future. Thanks a lot for your guidance. Thank you.