Closed pranav1698 closed 5 years ago
@xeon-zolt please review it now
Plus why do you commit a binary file?
The uploads was not present before I started working on the issue;
Hence every time I clicked the build button ; It was giving an uploads folder not found error
as we are saving the files in the uploads folder, hence I tweaked the tree by adding a uploads folder
Okay, You need a folder but why a 335 KB bin file?
Plus your heroku deployment link seems broken https://git.heroku.com/stormy-tundra-18408.git
Yeah, a lot changes is made, and we are still not clear I am also having some better ideas to approach this pr I think we can get a clear of what needa to be done when other contributors give their reviews
I have added some changes that will make it clear of what I am tying to do Seperate files are noe being uploaded in the uploads folder: @tabesin please review now
Have subdirs: wallpaper, desktopzip and logo. So we don't mix it up.
Checklist
master
branch.Short description of what this resolves:
The input files are now taken from the form in the generator and stored in the
files
section of the uploads directoryChanges proposed in this pull request:
Link to heroku build:- https://git.heroku.com/stormy-tundra-18408.git
Fixes #300