fossasia / meilix-generator

WebApp for generating a custom ISO image based on Meilix http://meilix.org
GNU Lesser General Public License v3.0
1.53k stars 113 forks source link

This uploads all input files in a seperate directory `files`- (Solves- #300) #303

Closed pranav1698 closed 5 years ago

pranav1698 commented 5 years ago

Checklist

Short description of what this resolves:

The input files are now taken from the form in the generator and stored in the files section of the uploads directory

Changes proposed in this pull request:

Link to heroku build:- https://git.heroku.com/stormy-tundra-18408.git

Fixes #300

pranav1698 commented 5 years ago

@xeon-zolt please review it now

tabesin commented 5 years ago

Plus why do you commit a binary file?

pranav1698 commented 5 years ago

The uploads was not present before I started working on the issue; Hence every time I clicked the build button ; It was giving an uploads folder not found error as we are saving the files in the uploads folder, hence I tweaked the tree by adding a uploads folder

tabesin commented 5 years ago

Okay, You need a folder but why a 335 KB bin file?

tabesin commented 5 years ago

Plus your heroku deployment link seems broken https://git.heroku.com/stormy-tundra-18408.git

pranav1698 commented 5 years ago

Yeah, a lot changes is made, and we are still not clear I am also having some better ideas to approach this pr I think we can get a clear of what needa to be done when other contributors give their reviews

pranav1698 commented 5 years ago

I have added some changes that will make it clear of what I am tying to do Seperate files are noe being uploaded in the uploads folder: screenshot from 2018-10-24 10-52-18 @tabesin please review now

tabesin commented 5 years ago

Have subdirs: wallpaper, desktopzip and logo. So we don't mix it up.