Optimize build.html on the /output route for mobiles - Githubissues

fossasia / meilix-generator

WebApp for generating a custom ISO image based on Meilix http://meilix.org

GNU Lesser General Public License v3.0

1.53k stars 113 forks source link

Optimize build.html on the /output route for mobiles #304

Closed rahulkumaran closed 5 years ago

rahulkumaran commented 5 years ago

Checklist

[x] I have read the Contribution & Best practices Guide and my PR follows them.
[x] There is a corresponding issue for this pull request.
[x] My branch is up-to-date with the Upstream master branch.
[ ] The unit tests pass locally with my changes (provide a screenshot or link for test)
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Short description of what this resolves:

This PR essentially makes sure that the build.html file has been optimised when viewed on mobile devices too. Before Optimization

After Optimization

Changes proposed in this pull request:

Add link for email.css stylesheet in layout.html
Optimise build.html for mobile devies

Fixes #301

pranav1698 commented 5 years ago

Nice work @rahulkumaran, I think we should also decrease the size of those email-provider images as we switch to mobile size

rahulkumaran commented 5 years ago

Thanks @pranav1698 ! Yeah, I was thinking of the same. But let's see what the others have to say! Open to mods as per the reviews haha :smile:

xeon-zolt commented 5 years ago

@rahulkumaran can we use better design doesn't look good

rahulkumaran commented 5 years ago

@r0mflip @tabesin, sure! Will update it by Friday. Currently have my exams going on

r0mflip commented 5 years ago

Currently have my exams going on

@rahulkumaran :rofl: me too