search

fossasia / meilix-generator

WebApp for generating a custom ISO image based on Meilix http://meilix.org
GNU Lesser General Public License v3.0
1.53k stars 113 forks source link

Implement file checking #309

Closed tabesin closed 5 years ago

tabesin commented 5 years ago

I'm submitting a ... (check one with "x")

Actual Behaviour At present file checking is only for one upload type implemented, with ALLOWED_EXTENSIONS_DESKTOP as a fragment reminder what also could be checked.

Expected Behaviour

Check for all upload types. Note that adding an upload file in all three instances is not mandatory. The functions / templates need to be a bit abstracted.

Related code: see app.py

Would you like to work on the issue?

no, that should be for GCI.

ammarbinfaisal1 commented 5 years ago

At present file checking is only for one upload type implemented

If I am correct this isn't the case now.
ALLOWED_EXTENSIONS_WALLPAPER, ALLOWED_EXTENSIONS_LOGO, ALLOWED_EXTENSIONS_DESKTOP are being checked now.
or am I misunderstanding something

tabesin commented 5 years ago

not properly

pranav1698 commented 5 years ago

Opening a new issue related to errors with file checking in the current site #381 and opening up a pr for the using function calls making it somewhat abstarct