Removed Empty Space in Navbar

rcya1 commented 5 years ago

Checklist

[X] I have read the Contribution & Best practices Guide and my PR follows them.
[X] There is a corresponding issue for this pull request.
[X] My branch is up-to-date with the Upstream master branch.
[X] The unit tests pass locally with my changes (provide a screenshot or link for test)
[X] I have added tests that prove my fix is effective or that my feature works
[X] I have added necessary documentation (if appropriate)

Short description of what this resolves:

There is unplesant white space in the navbar

screen shot 2018-10-24 at 11 49 57 am

Changes proposed in this pull request:

Changes the navbar size to make it larger and reduce whitespace.

screen shot 2018-10-24 at 11 49 07 am

Fixes #315

rpotter12 commented 5 years ago

@Ryan10145 for every frontend changes please paste the deployed heroku link. This will help us to review your PR more perfectly. Thank you

sarnava1 commented 5 years ago

@Ryan10145 yes you should submit heroku link for better and faster review. In some cases even screenshots work. And when your are filing a PR you have checked all the tickboxes. So you need to specify whoch tests you have carried out. @meets2tarun can help you more on this issue. Otherwise good going and keep it up.

sarnava1 commented 5 years ago

@Ryan10145 when you are doing frontend changes try to give the heights or paddings in % or vh vw rather than px since we need to make this web app responsive across all screens. @tabesin you can merge this as of now.

rpotter12 commented 5 years ago

@Ryan10145 always open an issue before creating any PR. Thank you :)

fossasia / meilix-generator