Fixed #311 Added styles to navbar

fossasia / meilix-generator

WebApp for generating a custom ISO image based on Meilix http://meilix.org

GNU Lesser General Public License v3.0

1.53k stars 113 forks source link

Fixed #311 Added styles to navbar #318

Closed supunTE closed 5 years ago

supunTE commented 5 years ago

Checklist

[x] I have read the Contribution & Best practices Guide and my PR follows them.
[x] There is a corresponding issue for this pull request.
[x] My branch is up-to-date with the Upstream master branch.

Short description of what this resolves:

I fixed issue #311. I added some styles to navbar to harmonise the logo and the top bar as the issue.

And I added a hover effect.

Changes proposed in this pull request:

Change the color of nav bar.
Add a hover effect to the navbar.

Fixes #311

Thank you! @tabesin Can you have a look?

sarnava1 commented 5 years ago

@STEdirisuriya Thank you for the PR. I see you have checked all the tickboxes. Can you tell me what tests you have carried out. If you have not carried out any test then please do not tick those boxes from the next time. Also it would have been good if you had given a preview link. Anyways LGTM @tabesin @mariobehling @meets2tarun .

supunTE commented 5 years ago

@STEdirisuriya Thank you for the PR. I see you have checked all the tickboxes. Can you tell me what tests you have carried out. If you have not carried out any test then please do not tick those boxes from the next time. Also it would have been good if you had given a preview link. Anyways LGTM @tabesin @mariobehling @meets2tarun .

@sarnava1 sorry for my mistake. I removed it now. Thank you!

tabesin commented 5 years ago

You should then also change the color of the black elements to white.

supunTE commented 5 years ago

@tabesin I changed it. Thanks.

abishekvashok commented 5 years ago

Task link: https://codein.withgoogle.com/dashboard/task-instances/4663115040948224/