Optimise build.html in /output route for mobiles

fossasia / meilix-generator

WebApp for generating a custom ISO image based on Meilix http://meilix.org

GNU Lesser General Public License v3.0

1.53k stars 113 forks source link

Optimise build.html in /output route for mobiles #321

Closed rahulkumaran closed 5 years ago

rahulkumaran commented 5 years ago

Checklist

[x] I have read the Contribution & Best practices Guide and my PR follows them.
[x] There is a corresponding issue for this pull request.
[x] My branch is up-to-date with the Upstream master branch.
[ ] The unit tests pass locally with my changes (provide a screenshot or link for test)
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Short description of what this resolves:

This PR makes sure that build html looks better on mobile phones. Had to close the previous pr

Changes proposed in this pull request:

added email.css link to layout.html
added width for images in build.html
add margin in email.css

Fixes #301 Had to close my previous PR #304 as there were some issues with it. The same changes can be viewed on https://rahulkumaran-meilix.herokuapp.com

show

rahulkumaran commented 5 years ago

So that is something that I can add if I put some
but I'm not able to edit the css for the margin. In the previous PR I added the break statements but later removed it on request. So yeah, if the spacing is needed then I'll have to add the break statements. @tabesin @meets2tarun

sarnava1 commented 5 years ago

@rahulkumaran why can't we edit the css for the margin?

rahulkumaran commented 5 years ago

Idk! Tried it out but wasn't happening! The br thing was the only one that worked

sarnava1 commented 5 years ago

@rahulkumaran ohh!!! Okay let's see what the others are saying @mariobehling @tabesin @meets2tarun

pranav1698 commented 5 years ago

LGTM, if you would have posted a heroku link then we could also try to see if margin works or not

rahulkumaran commented 5 years ago

@pranav1698, I've posted the heroku link in the PR description. Have a look haha

pranav1698 commented 5 years ago

Sorry for not checking it clearly @rahulkumaran

rahulkumaran commented 5 years ago

@pranav1698 don't be! It's totally cool, happens sometimes.

pranav1698 commented 5 years ago

I have checked it adding margin-bottom to the css and putting a positive value in it will solve this; screenshot from 2018-10-31 01-09-42 You can give a unique id to this container tag to avoid inline-css

rahulkumaran commented 5 years ago

Exactly I tried that. But it's not responding to the changes. It works with inline but in my previous PR I was suggested not to use inline so I tried shifting it an ID and gave the CSS stuff in the email.css file but to no effect. I shall try it out again though. I just realised I gave the ID in the wrong div tag. @pranav1698

rahulkumaran commented 5 years ago

@pranav1698, works well now. Tried it in the wrong place previously. Thanks for the help ! Check the heroku link now ! Should work perfectly alright.

pranav1698 commented 5 years ago

@rahulkumaran feels great to be of help, Post the screenshot of the present build

rahulkumaran commented 5 years ago

@pranav1698 @sarnava1 @tabesin @mariobehling @meets2tarun

pranav1698 commented 5 years ago

LGTM :+1:

rpotter12 commented 5 years ago

@rahulkumaran Your heroku link is not working properly. After clicking on build button an error is coming "unexpected Travis tag". Please solve this:)

rahulkumaran commented 5 years ago

It works perfectly for me and I guess the others also have already used the link! @rpotter12 Not sure why you're getting that error! Will check though

rpotter12 commented 5 years ago

@meets2tarun please check the heroku deployment link, is that working for you also??

rahulkumaran commented 5 years ago

@tabesin @meets2tarun @mariobehling, could please review this? Thanks! 😁