Added a new line for the email input field

fossasia / meilix-generator

WebApp for generating a custom ISO image based on Meilix http://meilix.org

GNU Lesser General Public License v3.0

1.53k stars 113 forks source link

Closed sahilsaha7773 closed 5 years ago

sahilsaha7773 commented 5 years ago

[x] I have read the Contribution & Best practices Guide and my PR follows them.
[x] There is a corresponding issue for this pull request.
[x] My branch is up-to-date with the Upstream master branch.
[x] The unit tests pass locally with my changes (provide a screenshot or link for test)
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)
Short description of what this resolves:

Added a new line for the email input field.

Fixes #354

Before:

After:

sahilsaha7773 commented 5 years ago

@sarnava1 Done!!

sahilsaha7773 commented 5 years ago

@pranav1698 ok I am doing it

pranav1698 commented 5 years ago

Rests looks good to me

sahilsaha7773 commented 5 years ago

Done!!

sarnava1 commented 5 years ago

@tabesin @meets2tarun please merge this PR.

sahilsaha7773 commented 5 years ago

@abishekvashok I did the same first but was requested by @pranav1698 to do it in some other way

pranav1698 commented 5 years ago

I thought that external css added is better than br tags in the html code Moreover mrgin styles will make it more responsive for mobile devices

You cannot add any bootstrap class on a br tag it will not work

sarnava1 commented 5 years ago

@pranav1698 I second you.

sahilsaha7773 commented 5 years ago

Please review @abishekvashok

sahilsaha7773 commented 5 years ago

@rpotter12 will not my commits get deleted if I merge now with the upstream?

rpotter12 commented 5 years ago

@sahilsaha7773 you have to rebase you PR

sahilsaha7773 commented 5 years ago

Oops, sorry I have messed up all the commits. I am creating another PR.