Browser Home Page accepts wider variety of URLs

PulkitMishra commented 5 years ago

Checklist

[x] I have read the Contribution & Best practices Guide and my PR follows them.
[x] There is a corresponding issue for this pull request.
[x] My branch is up-to-date with the Upstream master branch.
[x] The unit tests pass locally with my changes (provide a screenshot or link for test)
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)

Short description of what this resolves:

Solves issue #331 Browser Home page input field now accepts urls with or without https As @imahumanrcw pointed out and @meets2tarun @sarnava1 seemed to agree that people normally enter 'www.google.com' instead of 'https://www.google.com/' (just an example) so the website must take that into account people entering the former type of url also.

Changes proposed in this pull request:

Updated Regular Expression Value in the pattern attribute.

Fixes #331

Preview

PulkitMishra commented 5 years ago

@pranav1698 I had provided the wrong link in preview initially, apologies for the same . Please check now. Also by all url inputs do you mean the one for default search engine? If that is the case consider it done.

PulkitMishra commented 5 years ago

@pranav1698 seems to work. Please check. Although I don't quite understand, pattern is supposed to override input type. Nonetheless, your suggestion works as required.

pranav1698 commented 5 years ago

@rpotter12 it works for me, www.google.com is accepted in my case

PulkitMishra commented 5 years ago

@rpotter12 could you please recheck? Works fine for me.

PulkitMishra commented 5 years ago

@rpotter12 done.

fossasia / meilix-generator