This adds option for choice of processor using the 64bit support toggle - (Solves- #409)

pranav1698 commented 5 years ago

Checklist

[x] I have read the Contribution & Best practices Guide and my PR follows them.
[x] There is a corresponding issue for this pull request.
[x] My branch is up-to-date with the Upstream master branch.
[ ] The unit tests pass locally with my changes (provide a screenshot or link for test)
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Short description of what this resolves:

This adds an option for choice of processor(64bit or 32bit) using the bit support toggle Now, we can add an option on the build scripts in the main repo for 32bit or 64bit support

Changes proposed in this pull request:

Adding a name,value pair for the 64bit support toggle
Storing the value of the toggle in a variable named processor
The processor variable is then sent to the build server

Fixes #409

pranav1698 commented 5 years ago

Hosted site: https://shielded-coast-16793.herokuapp.com/

pranav1698 commented 5 years ago

@tabesin we can ignore the codacy error, it will not effect the working of the webapp and I think it is a good practise to having spaces between defining the variables, Also, I am taking that the default version is 32bit for this pr, whereas we are using the 64bit as default for the meilix main repo, so I think 64bit should be considered as default

tabesin commented 5 years ago

yes 64 bit as default. Also for the normal build run without webapp trigger.

pranav1698 commented 5 years ago

@tabesin, That is been taken care in the meilix repo opened a pr for that: https://github.com/fossasia/meilix/pull/422 I will update for 64bit as default

pranav1698 commented 5 years ago

@tabesin please review now

pranav1698 commented 5 years ago

@rpotter12 I have rebased my heroku master branch as I have started working on other issue Please merge it the functionality remains the same for the generator

pranav1698 commented 5 years ago

Conflicts resolved @tabesin please merge

fossasia / meilix-generator