flask secret key initialization using an env variable - Githubissues

fossasia / meilix-generator

WebApp for generating a custom ISO image based on Meilix http://meilix.org

GNU Lesser General Public License v3.0

1.53k stars 113 forks source link

flask secret key initialization using an env variable #421

Closed alok760 closed 5 years ago

alok760 commented 5 years ago

Checklist

[x] I have read the Contribution & Best practices Guide and my PR follows them.
[x] There is a corresponding issue for this pull request.
[x] My branch is up-to-date with the Upstream master branch.
[ ] The unit tests pass locally with my changes (provide a screenshot or link for test)
[ ] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)

Short description of what this resolves:

app.secret_key now uses environment variable for initialisation instead of being hardcoded

Fixes #420

xeon-zolt commented 5 years ago

now we should be adding secrete key to Heroku env