fossasia / meilix-generator

WebApp for generating a custom ISO image based on Meilix http://meilix.org
GNU Lesser General Public License v3.0
1.53k stars 113 forks source link

Add documentation for configuring flask secret key #424

Open alok760 opened 5 years ago

alok760 commented 5 years ago

I'm submitting a ... (check one with "x")

Actual Behaviour There is no documentation for configuring flask secret key.

Expected Behaviour

Related code: https://github.com/fossasia/meilix-generator/blob/35a2bb78fc17138d5f64c2a40fbd94025bfdbb08/app.py#L25-L26

pranav1698 commented 5 years ago

It would be great if this could be hidden

xeon-zolt commented 5 years ago

the original secrete key is different

pranav1698 commented 5 years ago

Also, I think this would require admin rights from the heroku server but you can test it for your local development

xeon-zolt commented 5 years ago

i have already changed it

Patil2099 commented 4 years ago

Can I work on this ? If yes can you explain how to add something to documentation. Also # Initializing flask secret key using the environment variable "secret_key" app.secret_key = os.environ.get('secret_key', 'z528&^FJjhd_t2bxc#$2').encode() what is the second argument here? @alok760

alok760 commented 4 years ago

@Patil2099 the second argument is the default value. To change the secret key, you need to set an environment variable secret_key. You already need to set your Travis Key as an env variable, similarly, you need to set the flask secret key.