Unexpected error on clicking the build button

fossasia / meilix-generator

WebApp for generating a custom ISO image based on Meilix http://meilix.org

GNU Lesser General Public License v3.0

1.53k stars 112 forks source link

Unexpected error on clicking the build button #437

Closed pranav1698 closed 5 years ago

pranav1698 commented 5 years ago

I'm submitting a ... (check one with "x")

[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, instead ask your query in out Gitter channel at https://gitter.im/fossasia/meilix

Actual Behaviour The current build of the webapp on clicking the build button gives the following error: Sorry, unexpected error: str expected, not list

Steps to reproduce it

Fill up the form and click the build button
The webapp gives the following error: Sorry, unexpected error: str expected, not list

System information:

Ubuntu 18.04

Would you like to work on the issue? Yes

pranav1698 commented 5 years ago

@tabesin, the pr #436 was not required and it is causing this error if you see the codebase the recipe array and INSTALL array is the same we are just adding another environment variable which has already been added just with a different name, so I think we should stick with what was done previously Chrome is also not open-source and should not be an option for the ISO when we are already giving chromium as an option

rpotter12 commented 5 years ago

@pranav1698 according to https://github.com/fossasia/meilix-generator/issues/121 we have give option for chrome also and for INSTALL array I was implementing the solution in my way but get busy in college stuff.

pranav1698 commented 5 years ago

@rpotter12 I understand that but the same thing is happening with the recipe array you can check it on the codebase the response is already added