search

fossasia / open-event-attendee-android

Open Event Attendee Android General App https://github.com/fossasia/open-event-android/blob/apk/open-event-dev-app-playStore-debug.apk
Apache License 2.0
1.95k stars 551 forks source link

Get back to same item position when back button is clicked in Event Details #103

Closed dreadpool2 closed 6 years ago

dreadpool2 commented 6 years ago

What happens now : videotogif_2018 06 08_15 58 40

What should occur: The app should come back to the same item position

Working on it :+1:

iamareebjamal commented 6 years ago

Not required for now. Focus on features

dreadpool2 commented 6 years ago

Sure :+1:

iamareebjamal commented 6 years ago

@codedsun Look at this, this is a bug

codedsun commented 6 years ago

@iamareebjamal Working!

codedsun commented 6 years ago

@iamareebjamal I tried 2-3 ways of getting this, but I am not able to implement this properly. How canI send the adapter posiiton from EventDetails Fragment to the EventFragment on backPress?

codedsun commented 6 years ago

@iamareebjamal Do we add this fragment to backstack and retain thie state of the EventsFragment and on backpress pop it off?

iamareebjamal commented 6 years ago

No, normal recyclerview works fine. Check what's the issue with our implementation

codedsun commented 6 years ago

@iamareebjamal I am still not able to get it. Like, what I am thinking that onBackPress the recyclerView should be scrolled to the position of that event.

Like for example I clicked event with 5th position then on backpress, it should be scrolled to 5th directly. Tell me where I am going wrong?