Open RotBolt opened 5 years ago
@iamareebjamal could you give your opinion ?
Not all, only repeated ones
@iamareebjamal @mariobehling is it okay to convert gradle files to kts files ? We can use buildSrc with dependencies update gradle plugin.
Here are some other benefits to this : https://medium.com/mindorks/migrating-gradle-build-scripts-to-kotlin-dsl-89788a4e383a
MediumHowdy people! It’s bean a while since Gradle released support for Kotlin scripts. We have been writing Gradle script in a language called…
Yes, please go ahead and share before and after build durations after ./gradlew clean
@iamareebjamal almost done with the kotlin dsl, the build times are as follows (benchmarked with hyperfine)
Groovy Clean Build - 171.838s Next Build - 13.375s
Kotlin Clean Build - 149.667s Next Build - 10.113s
However i had some difficulty with signingConfigs and playStoreImplementation
1) Are signingConfig variables like SIGNING_KEY_FILE, ALIAS, KEY_ALIAS and STORE_PASS in local.properties because the gradle local properties plugin is not compatible with kotlin dsl.
2) Is playStoreImplementation a custom config because the kotlin dsl cannot find it.
@Skrilltrax playStoreImplementation is a flavour specifc dependency configuration
@iamareebjamal I'm doing both but i am not using the plugin, so should i remove it ? can you also please confirm if i should keep AndroidConfig object in the PR, I made it but then it seemed kinda overkill.
@adityastic Thanks, the dsl does not automatically recognise it so i'll be using property delegation for that.
Remove both
Updated PR
Describe the chore Make a separate
dependencies
file to list all dependencies version number / libraries versions and reference those versions inbuild.gradle
filesThis would include
dependencies.gradle
file which would contain all versions of dependencies/ libraries used . This would help us in maintaining/ adding the future dependencies .Would you like to work on the issue?