Memory leaks when setting up Recycler/Adapter

[anhanh11001]

Describe the bug In most fragment, setting up RecyclerView and Adapter leads to memory leaks reported by Leak Canary

Screenshots

Additional context

1705 related issue

Would you like to work on the issue? Yes

[iamareebjamal]

Reopening because there might be other reasons for memory leaks. Please check @anhanh11001

[anhanh11001]

@liveHarshit can you also take a look at this issue as well, I'm not sure for now

[liveHarshit]

@liveHarshit can you also take a look at this issue as well, I'm not sure for now

Sure :+1: This issue needs to divide into different parts. There are multiple memory leaks. We can list them manually and solve them.

[liveHarshit]

@anhanh11001 @iamareebjamal What if we use data bindings for fragments instead of using lateinit rootView, I think it is causing for memory leaks.

[iamareebjamal]

It's not. The listeners are causing the memory leak. If you use the binding. binding and hence, the root view will get leaked

[liveHarshit]

Okay and leaking always starts with message Fragment#mFragmentManager is not null in case of recycling adapters, I don't understand what it's mean?

[iamareebjamal]

Doesn't matter. It means that the fragment fragmentmanager is not null and thus leaked, leaking the fragment

[iamanbansal]

DiffCallBack could also be the cause? I am not sure

[iamareebjamal]

Just remove the listeners in onDestroyView

[iamanbansal]

or make it static?

[iamareebjamal]

Then change the title to "Add more memory leaks"

[liveHarshit]

Just remove the listeners in onDestroyView

Click listeners are removed in #1766 But still, there are memory leaks with recycler adapters -

[iamareebjamal]

These clearly show swipe refresh listener not being removed

[liveHarshit]

These clearly show swipe refresh listener not being removed

But it is set to null - https://github.com/fossasia/open-event-android/blob/91eda72bab0ed86f564ed26d259b7acb1eff7c7a/app/src/main/java/org/fossasia/openevent/general/event/EventsFragment.kt#L209

[iamareebjamal]

Will see what's happening

[adityastic]

@liveHarshit I encountered a similar issue, rootview was leaking for me. Try removing the rootview, Im not sure about open-event's codebase but someone did code the fragments similar to EventsFragment.kt

[anhanh11001]

@adityastic will try

[iamareebjamal]

Try removing the rootview

Not a solution

[iamanbansal]

also set adapter to null https://stackoverflow.com/questions/35520946/leak-canary-recyclerview-leaking-madapter

Stack Overflow

Leak canary, Recyclerview leaking mAdapter

I decided it was high time I learned how to use Leak Canary to detect Leaks within my apps, and as I always do, I tried to implement it in my project to really understand how to use the tool.

[anhanh11001]

also set adapter to null https://stackoverflow.com/questions/35520946/leak-canary-recyclerview-leaking-madapter

Stack OverflowLeak canary, Recyclerview leaking mAdapterI decided it was high time I learned how to use Leak Canary to detect Leaks within my apps, and as I always do, I tried to implement it in my project to really understand how to use the tool.

Tried, it worked. But Areeb said it is just a workaround, not a fix so it wasn't implemented. https://github.com/fossasia/open-event-attendee-android/pull/1766#issuecomment-492699626

Stack Overflow

Leak canary, Recyclerview leaking mAdapter

I decided it was high time I learned how to use Leak Canary to detect Leaks within my apps, and as I always do, I tried to implement it in my project to really understand how to use the tool.

[iamareebjamal]

@anhanh11001 It actually just prevents LeakCanary to report it as memory leak. It doesn't solve the memory leak