fossasia / open-event-droidgen

Open Event Android App Generator https://github.com/fossasia/open-event-android/raw/apk/sample-apk-fossasia17-development.apk
GNU General Public License v3.0
2.06k stars 828 forks source link

Adding About screen in the application #1275

Closed harshitagupta30 closed 7 years ago

harshitagupta30 commented 7 years ago

Actual Behaviour

Currently, we have no screen describing the event and its details.

Expected Behaviour

Adding an about screen containing all the required details about the event.

screenshot from 2017-03-09 17 45 57 screenshot from 2017-03-09 17 46 05

(This is sample UI improvements are need to be done in this.)

Would you like to work on the issue? yes

@the-dagger @mananwason What's your thoughts on this? Should I implement this?

the-dagger commented 7 years ago

Yes we definitely need this. :+1: But the current implementation looks a bit plain to me. How about you take a look at wither Facebook's F8 and Google io app to see how they are doing it.

Lastly, be sure not to include anything which is not provided by the event.json since that would be of no use and will have to be removed anyways.

On Thursday, March 9, 2017, Harshita Gupta notifications@github.com wrote:

Actual Behaviour

Currently, we have no screen describing the event and its details.

Expected Behaviour

Adding an about screen containing all the required details about the event.

[image: screenshot from 2017-03-09 17 45 57] https://cloud.githubusercontent.com/assets/12701036/23749881/55b07394-04f0-11e7-9f30-3f648a5f0d6e.png [image: screenshot from 2017-03-09 17 46 05] https://cloud.githubusercontent.com/assets/12701036/23749882/560fc664-04f0-11e7-912c-0d6a83fdf013.png

(This is sample UI improvements are need to be done in this.)

Would you like to work on the issue? yes

@the-dagger https://github.com/the-dagger @mananwason https://github.com/mananwason What's your thoughts on this? Should I implement this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fossasia/open-event-android/issues/1275, or mute the thread https://github.com/notifications/unsubscribe-auth/AGQtlhCLcnwwHZ7TlDCc3NigBwq43r6Iks5rj-3CgaJpZM4MYAjx .

-- Best, Harshit Dwivedi

harshitagupta30 commented 7 years ago

This is just a mock screen. I'll try to make it look better. Yes I'll add data keeping that in mind. Thanks 👍

On Mar 9, 2017 17:57, "Harshit Dwivedi" notifications@github.com wrote:

Yes we definitely need this. :+1: But the current implementation looks a bit plain to me. How about you take a look at wither Facebook's F8 and Google io app to see how they are doing it.

Lastly, be sure not to include anything which is not provided by the event.json since that would be of no use and will have to be removed anyways.

On Thursday, March 9, 2017, Harshita Gupta notifications@github.com wrote:

Actual Behaviour

Currently, we have no screen describing the event and its details.

Expected Behaviour

Adding an about screen containing all the required details about the event.

[image: screenshot from 2017-03-09 17 45 57] https://cloud.githubusercontent.com/assets/12701036/23749881/55b07394- 04f0-11e7-9f30-3f648a5f0d6e.png [image: screenshot from 2017-03-09 17 46 05] https://cloud.githubusercontent.com/assets/12701036/23749882/560fc664- 04f0-11e7-912c-0d6a83fdf013.png

(This is sample UI improvements are need to be done in this.)

Would you like to work on the issue? yes

@the-dagger https://github.com/the-dagger @mananwason https://github.com/mananwason What's your thoughts on this? Should I implement this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fossasia/open-event-android/issues/1275, or mute the thread https://github.com/notifications/unsubscribe-auth/ AGQtlhCLcnwwHZ7TlDCc3NigBwq43r6Iks5rj-3CgaJpZM4MYAjx .

-- Best, Harshit Dwivedi

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/fossasia/open-event-android/issues/1275#issuecomment-285338293, or mute the thread https://github.com/notifications/unsubscribe-auth/AMHNbIWXFpO0Zrr8pyLIt1A0-lH-BDC4ks5rj_A5gaJpZM4MYAjx .

m-murad commented 7 years ago

@the-dagger @harshitagupta30 This was proposed earlier in #751 . But there is no data in the JSONs that can be used for this activity.

Correct me if I am wrong.

the-dagger commented 7 years ago

You can take the data from event.json

On Thursday, March 9, 2017, Murad notifications@github.com wrote:

@the-dagger https://github.com/the-dagger @harshitagupta30 https://github.com/harshitagupta30 This was proposed earlier also. But there is no data in the JSONs that can be used for this activity.

Correct me if I am wrong.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fossasia/open-event-android/issues/1275#issuecomment-285339349, or mute the thread https://github.com/notifications/unsubscribe-auth/AGQtljS9aXRhEHH6sYqClD5yp3mXMRlcks5rj_FygaJpZM4MYAjx .

-- Best, Harshit Dwivedi

harshitagupta30 commented 7 years ago

screenshot_20170310-204520 screenshot_20170310-204523

@the-dagger Checked different apps but about page is very plain in every app! Can you give your suggestions on how it can be improved?

mananwason commented 7 years ago

@harshitagupta30 This seems a lot of continuous text. Maybe breaking it down using dividers, different sizes etc. be better Plus you can add contributors list, add a mapview under menu etc.

These are some ideas of the top of my mind

gautamp8 commented 7 years ago

@harshitagupta30, you could try adding dividers and setting max lines in text views with longer descriptions. Adding a read more link with ellipsis would be a good improvement in UX.

If you want to try something even better, go with Card UI and expand them with animation for longer descriptions. You can look at cardslib repo https://github.com/gabrielemariotti/cardslib for UI inspiration.

On Sat, Mar 11, 2017 at 12:18 AM, Manan Wason notifications@github.com wrote:

@harshitagupta30 https://github.com/harshitagupta30 This seems a lot of continuous text. Maybe breaking it down using dividers, different sizes etc. be better Plus you can add contributors list, add a mapview under menu etc.

These are some ideas of the top of my mind

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/fossasia/open-event-android/issues/1275#issuecomment-285752044, or mute the thread https://github.com/notifications/unsubscribe-auth/AJE8R5MkK_djO2zO68Tpnfbev1ceW0WEks5rkZr9gaJpZM4MYAjx .

harshitagupta30 commented 7 years ago

@the-dagger @mananwason I've tried to make it look better, attaching the screenshots. screenshot_20170312-220033 screenshot_20170312-220038 screenshot_20170312-220043 screenshot_20170312-220050

I am also planning to add all the social links at bottom related to FOSSASIA at the bottom.