fossasia / open-event-droidgen

Open Event Android App Generator https://github.com/fossasia/open-event-android/raw/apk/sample-apk-fossasia17-development.apk
GNU General Public License v3.0
2.06k stars 828 forks source link

Loading Bar in Main Activity #2258

Open jindalAnuj opened 6 years ago

jindalAnuj commented 6 years ago

Actual Behaviour

There is no loading bar in main activity if anybody use app with slow internet connection then user may end up uninstalling the app.This all happens when app is opened first time

Expected Behaviour

There should be a loading bar in the main ativity

Steps to reproduce it

open App first time after installing

Screenshots of the issue

ezgif com-video-to-gif 1

Would you like to work on the issue? yes

simarsingh24 commented 6 years ago

@jindalAnuj it has no connection with your connectivity when you hit NO it actually downloads from the example JSON file (located inside assets)

jindalAnuj commented 6 years ago

@simarsingh24 still it get data from a local JSON file which consume time so a loading bar is necessary. In local json case if a user with a lot of app running in background app may take a lot of time and app may crash in that case if user is allowed to click. Because sometimes user gets frustrated with such kind of Empty views

iamareebjamal commented 6 years ago

There is a loading bar. It is just not getting triggered at the right time, You can see that if you look closely that it gets triggered just before it is closed. I noticed the bug and forgot to report. Please go ahead and fix this

prachi0311 commented 6 years ago

@jindalAnuj @iamareebjamal Can i work on this issue?

Actual Behaviour Loading bar not triggered at the right time.

Expected Behaviour Loading bar should show at the starting of the downloading of data

Steps to reproduce it

  1. Open App first time after installing
  2. Click no when promoted to download data

OR

  1. Clear app data if already installed, open app again.
  2. Click no when promoted to download data
jindalAnuj commented 6 years ago

@prachi0311 i am working on it currently

simarsingh24 commented 6 years ago

@jindalAnuj what is the status of this issue? are you still on it?

jindalAnuj commented 6 years ago

I am busy im my examination your can take it @simarsingh24

rishabhkalra96 commented 6 years ago

Is the issue still active?