search

fossasia / open-event-droidgen

Open Event Android App Generator https://github.com/fossasia/open-event-android/raw/apk/sample-apk-fossasia17-development.apk
GNU General Public License v3.0
2.06k stars 828 forks source link

Speakers' color changes in SpeakerListFragment when search is being done #2348

Closed leeyh20 closed 6 years ago

leeyh20 commented 6 years ago

Actual Behaviour Speakers' color changes in SpeakerListFragment when search is being done

Expected Behaviour Speakers' color should not change in SpeakerListFragment when search is being done

Screenshots of the issue bugatspeakers

See the speaker on the top right. His panel changes from red to blue. It sometimes changes to yelllow too.

Would you like to work on the issue? Yes, though I'm not sure where the colors of the speakers are set. Has this issue been reported before?

iamareebjamal commented 6 years ago

It is set in the Speaker ViewHolder as far as I know. It may be a bug in Android Color Palette

leeyh20 commented 6 years ago

Thanks for pointing out where it is set! It is caused by some of the images not having a "vibrant" swatch profile, thus not setting its background color explicitly causes the change in color.

I have made a PR to solve this.