search

fossasia / open-event-droidgen

Open Event Android App Generator https://github.com/fossasia/open-event-android/raw/apk/sample-apk-fossasia17-development.apk
GNU General Public License v3.0
2.06k stars 828 forks source link

Events bookmarked on Schedule does not update the DayFragmentSchedule #2352

Open leeyh20 opened 6 years ago

leeyh20 commented 6 years ago

Actual Behaviour Adding a bookmark on an event won't update DayFragmentSchedule

Expected Behaviour

Adding a bookmark on an event should update DayFragmentSchedule

Steps to reproduce it

  1. Go to DayFragmentSchedule at "Schedule"
  2. Click any event like "Coffee Break" to see its details
  3. Bookmark the event
  4. Exit the event details view
  5. DayFragmentSchedule at "Schedule" does not show that the event has been bookmarked.

Screenshots of the issue bookmark

Would you like to work on the issue?

Yes but I think it might be related to #2318

@iamareebjamal Is this an related issue to #2318 ?

iamareebjamal commented 6 years ago

No, it is different

leeyh20 commented 6 years ago

@iamareebjamal Ok thanks I'll try to look into it!

sriramr98 commented 6 years ago

Is anyone working on this? I have fixed the bug and added some kotlin support. This might have also fixed issue #2318 . If no one has a solution, I would like to send a PR.

leeyh20 commented 6 years ago

@sriramr98 You can go ahead and send a PR for this issue! Sorry, was busy with school!

iamareebjamal commented 6 years ago

@sriramr98 If you do fix this, please be aware that we appreciate single PR per issue. Your PR may fix two related issues but not tackle a new one

sriramr98 commented 6 years ago

Okay. My PR will only fix this current issue. I will work on the related issue separately.