search

fossasia / open-event-droidgen

Open Event Android App Generator https://github.com/fossasia/open-event-android/raw/apk/sample-apk-fossasia17-development.apk
GNU General Public License v3.0
2.05k stars 828 forks source link

opening the event and removing the bookmark doesn't update the AboutFragment.java #2356

Closed raj10071997 closed 6 years ago

raj10071997 commented 6 years ago

Actual Behaviour

On opening an event in the bookmark recycler view of AboutFragment.java and removing the bookmark doesn't remove the event from the list. Instead only the bookmark sign is removed.

Expected Behaviour

The event should be removed from the list.

Gif of the issue

videotogif_2018 03 07_19 49 13

Would you like to work on the issue?

Yes.

sriramr98 commented 6 years ago

Is someone working on this issue? I have the fix and I would like to send a PR.

iamareebjamal commented 6 years ago

Adding the listener in onResume is a hack and not a fix. Do you have any other fix? :smile:

sriramr98 commented 6 years ago

I haven't yet sent a PR for this issue. You've commented on the wrong issue.

iamareebjamal commented 6 years ago

Just discussing your approach to the solution

ParthivMangukiya commented 6 years ago

@iamareebjamal Apologies, I hadn't known this issue was open. This has been fixed by #2383.