Add appropriate message in notifications fragment when not logged in

[ParthivMangukiya]

Actual Behaviour

Empty view shows "No Notifications" in notification fragment when not logged in.

Expected Behaviour

Empty view should show appropriate message in notification fragment when not logged in.

Screenshots of the issue

Would you like to work on the issue?

yes

[iamareebjamal]

Showing custom message when you are directly navigated out seems like an overkill

[ParthivMangukiya]

@iamareebjamal I think that navigation flow of opening notification fragment is something odd. If user do not want to login then he have to do two click, one to exit login activity and one for going elsewhere. In my point of view the good flow would be If user click notification in drawer, than he find out he should login to see notification message. There should be Login button at the bottom if he want to login.

But to add login button is out of this issue, so I only updated empty view message.

Please give suggestion, If this flow good than I will create new issue to change navigation flow.

[iamareebjamal]

Yes, please address this issue in a separate PR and also do it for any other fragment which needs the user to be logged in