search

fossasia / open-event-droidgen

Open Event Android App Generator https://github.com/fossasia/open-event-android/raw/apk/sample-apk-fossasia17-development.apk
GNU General Public License v3.0
2.06k stars 828 forks source link

Add appropriate empty message in notifications fragment when not logged in #2370

Closed ParthivMangukiya closed 6 years ago

ParthivMangukiya commented 6 years ago

Fixes #2369

Changes: Added appropriate message "Please Login to see Notifications" in Notification Fragment when not logged in.

Screenshots for the change:

20180311_233921

ParthivMangukiya commented 6 years ago

@iamareebjamal i have moved setText in onCreateView method. Please Review.

ParthivMangukiya commented 6 years ago

@iamareebjamal Should I make this change in current PR or #2372 ? Please review this so that I can send appropriate PR for #2372.

iamareebjamal commented 6 years ago

Send a new PR please. Also use a common string, login to continue

ParthivMangukiya commented 6 years ago

@iamareebjamal As I have commit this changes in #2378 PR, this PR and Issue is no longer needed. Can I close this issue and PR?

iamareebjamal commented 6 years ago

Yes