search

fossasia / open-event-droidgen

Open Event Android App Generator https://github.com/fossasia/open-event-android/raw/apk/sample-apk-fossasia17-development.apk
GNU General Public License v3.0
2.06k stars 828 forks source link

added scroll bar in speakerslistfragment #2394

Closed sriramr98 closed 6 years ago

sriramr98 commented 6 years ago

Fixes #2207 Changes: Added a scroll bar in SpeakersListFragment which acts as a fast scroller. Scrolling using the scroll bar shows the starting alphabet of the name of the speaker in a bubble.

Screenshot :

gif

sriramr98 commented 6 years ago

@iamareebjamal please review this PR. I would recommend we reduce the width of each item. Because we cant bring the scroller any closer to the right end and it collides with the recycler view item. So I think we should either reduce the width a little bit or convert the staggered grid into a linear layout recycler view

iamareebjamal commented 6 years ago

Simple, rather than using margin in recyclerview, use padding

iamareebjamal commented 6 years ago

Please add a gif of the functionality

sriramr98 commented 6 years ago

@iamareebjamal added gif

iamareebjamal commented 6 years ago

Scroller should align to right

sriramr98 commented 6 years ago

The scroller is at right.

iamareebjamal commented 6 years ago

Not all the way

sriramr98 commented 6 years ago

Any more right and the user won't be able to drag it properly. And that's the default margin from the library. I haven't added any margin to the scroller as you can see.

iamareebjamal commented 6 years ago

Alright

sriramr98 commented 6 years ago

@iamareebjamal This PR can be merged.