search

fossasia / open-event-droidgen

Open Event Android App Generator https://github.com/fossasia/open-event-android/raw/apk/sample-apk-fossasia17-development.apk
GNU General Public License v3.0
2.06k stars 828 forks source link

Enhance UI of the filter dialog #2406

Open mayank8318 opened 6 years ago

mayank8318 commented 6 years ago

Actual Behaviour

It is a standard alert dialog with a list of filters.

Expected Behaviour

Enhance the UI to use the track colours for checkboxes. Something like this - image

Taken from Mifos self-service-app.

Steps to reproduce it

Go to schedule and open filters

Would you like to work on the issue?

Yes

mayank8318 commented 6 years ago

@iamareebjamal What is your opinion regarding this?

iamareebjamal commented 6 years ago

@mayank8318 We need to change the implementation of filtering, so if you can take that up, this change will be included there as well

mayank8318 commented 6 years ago

@iamareebjamal I would love to do it. What exactly is required on the issue?

iamareebjamal commented 6 years ago

Correspond to #2066

The filter functionality uses arrays and a lot of unnecessary calculation. We have to reimplement it. Basically, come up with a new solution imagining there isn't one and then change the implementation to that

mayank8318 commented 6 years ago

@iamareebjamal Ok on it :)