fix : profile pic error fixed

fossasia / open-event-droidgen

Open Event Android App Generator https://github.com/fossasia/open-event-android/raw/apk/sample-apk-fossasia17-development.apk

GNU General Public License v3.0

2.06k stars 828 forks source link

fix : profile pic error fixed #2423

Closed dreadpool2 closed 6 years ago

dreadpool2 commented 6 years ago

Fixes #2416

Changes: Used PackageManager for External Storage permissions in EditProfileActivity A permission dialog is visible once the user enters the profile details page.

dreadpool2 commented 6 years ago

@iamareebjamal I apologise for the silly error!. PR updated

dreadpool2 commented 6 years ago

@iamareebjamal PR updated

dreadpool2 commented 6 years ago

@iamareebjamal Is there a requirement to change the PR ?

dreadpool2 commented 6 years ago

@iamareebjamal PR updated

iamareebjamal commented 6 years ago

@dreadpool2 How does finalizing the PR mean closing it? A simple callback is to be implemented to handle the permission grant/deny. The user is to be notified of the action and the action is to be proceeded with or the activity has to close respectively

dreadpool2 commented 6 years ago

@iamareebjamal Apologies :sweat_smile: , I thought that all PRs needed to be closed by now. I will work on it straightahead

dreadpool2 commented 6 years ago

@iamareebjamal The current state of the app is that whenever the user is clicking on the profile pic , a dialog for requesting external storage permission is fired. Until and unless the user grants permission the dialog will always be fired.

simarsingh24 commented 6 years ago

@dreadpool2 you are not using a callback when permission is granted

simarsingh24 commented 6 years ago

https://developer.android.com/training/permissions/requesting#java read this

dreadpool2 commented 6 years ago

@simarsingh24 Thanks a lot. Got the point :+1:

dreadpool2 commented 6 years ago

@iamareebjamal @simarsingh24 Please review

open-event-bot[bot] commented 6 years ago

Hi @dreadpool2!

It looks like one or more of your builds have failed. I've added the relevant info below to save you some time.

Build 5513.1 has failed

simarsingh24 commented 6 years ago

check why build is failing

open-event-bot[bot] commented 6 years ago

Hi @dreadpool2!

It looks like one or more of your builds have failed. I've added the relevant info below to save you some time.

Build 5514.1 has failed

open-event-bot[bot] commented 6 years ago

Hi @dreadpool2!

It looks like one or more of your builds have failed. I've added the relevant info below to save you some time.

Build 5515.1 has failed

dreadpool2 commented 6 years ago

Did the change :+1:

dreadpool2 commented 6 years ago

@iamareebjamal Please review :+1:

dreadpool2 commented 6 years ago

@iamareebjamal Please Review

dreadpool2 commented 6 years ago

@iamareebjamal Added the Toast messages :+1: