Enhance language dropdown button - Githubissues

fossasia / open-event-frontend

The frontend for the Open Event API Server https://test.eventyay.com

https://eventyay.com

Apache License 2.0

2.34k stars 1.82k forks source link

Enhance language dropdown button #9082

Open mariobehling opened 1 year ago

mariobehling commented 1 year ago

The language dropdown button does not adhere to the design of the sidebar. The design is not a real dropdown menu. Please enhance as follows and shown in the below screenshot

Make it into a "real" dropdown and when the user clicks another language keep showing that language in the dropdown, e.g. the user clicks on Vietnamese, then the button should show Vietnamese.
Increase size of language symbol
Instead of "6 Languages" simply show ❻
Change color of font to the same as the sidebar color
Reduce height and width of light gray button area
Ensure spacing between "room name" and language dropdown even with long room names

Screenshot from 2023-08-12 00-01-11b

mariobehling commented 1 year ago

Last PR does not work. Compare https://test.eventyay.com/e/a86f2bbb?side_panel=true

Screenshot from 2023-08-17 07-42-46

nnhathung commented 1 year ago

Hi @mariobehling , the fix for this issue available on https://github.com/fossasia/open-event-frontend/pull/9131 Please help me to review it.

mariobehling commented 1 year ago

Tested it but it has some issues

Clicking between channels sometimes plays the sound of the previous video
Clicking between languages sometimes plays both audio channels

Screenshot from 2023-08-18 09-03-22

Reopening the issue. The previous implementation did not always work perfectly neither, but it never played two audio channels at the same time.

mariobehling commented 5 months ago

Reopening this issue as clicking on different streams and translations does not work properly.