Mobile navbar bug #9177 - Githubissues

fossasia / open-event-frontend

The frontend for the Open Event API Server https://test.eventyay.com

https://eventyay.com

Apache License 2.0

2.34k stars 1.82k forks source link

Mobile navbar bug #9177 #9179

Open Darkboy17 opened 5 months ago

Darkboy17 commented 5 months ago

Fixes #9177

Short description of what this resolves:

The mobile navbar which shifts content in x axis rather than overlapping on it now overlays above the content with no more x-axis content shift happening.

Changes proposed in this pull request:

Fixes #9177 : by applying a CSS class called "overlay" which seems to be coming from Semantic UI, a popular front-end framework.
Changes have been made in a file called side-bar.hbs under /components
The first line of code is where the change was made.
Screenshot of the fix

Checklist

[x] I have read the Contribution & Best practices Guide.
[x] My branch is up-to-date with the Upstream development branch.
[x] The acceptance, integration, unit tests and linter pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
open-event-frontend	❌ Failed (Inspect)			Jan 28, 2024 10:37am