fossasia / open-event-server

The Open Event Organizer Server to Manage Events https://test-api.eventyay.com
https://api.eventyay.com
GNU General Public License v3.0
2.98k stars 1.89k forks source link

Add good quality images to be used as placeholders for events without an event image #1845

Closed mariobehling closed 7 years ago

mariobehling commented 8 years ago

Currently if an event does not have an image, we show a gray placeholder image as below.

screenshot from 2016-07-24 19 25 17

For events that do not have images, we should find a better more colorful solution. A way to implement it, is to use the categories and subcategories, that are entered in the wizard step 1. screenshot from 2016-07-24 19 28 48

Please improve the visuals of the system by adding good quality images:

mariobehling commented 8 years ago

Please check if you find some better images and compare on Google image search what kind of images are most relevant.

Some hints

E.g. compare these search results for home and our "home" picture: screenshot from 2016-08-02 09 05 58

SaptakS commented 8 years ago

@mariobehling I did try finding images keeping all the above points in mind. Google doesn't show open licensed photos. And the photos I got from free and open licensed website were these.. I will try to find better.. I know some of them are not generic enough.. I also couldn't find any generic image for government and politics. The problem is we can only use open licensed images.

I will try finding better images again and then update this.

mariobehling commented 8 years ago

Please document, where you found the photos. Which services? And ask others for input.

mariobehling commented 8 years ago

First page of pixabay already shows suitable photos in great quality: https://pixabay.com

mariobehling commented 8 years ago

Please also add a dedicated photo for each subcategory. If subcategory is not chosen, use the photo of the main category.

screenshot from 2016-08-02 20 04 32

SaptakS commented 8 years ago

I searched in https://pixabay.com itself. And I will do for the subcategory as well..

mariobehling commented 8 years ago

@SaptakS Ok, maybe this is tricky and a better implementation would be to give the administrator the option to change the topic/subtopic image. So, please implement a standard image and give the admin the option to change it in a subtab of admin/content/ as defined in https://github.com/fossasia/open-event-orga-server/issues/2016

SaptakS commented 8 years ago

@mariobehling I was thinking about this as well. But suppose the administrator uses some premium images, it won't create issues for us, right?

mariobehling commented 8 years ago

No issue for us, as the admin will be responsible and we just care about our source code. Issue #2016 also outlines to create a form field for additional info about the image. The admin can add origina info and a link there, but we do not display that online. That is just for the internal info.

mariobehling commented 8 years ago

Images are implement on top of placeholder images slowing down the website. Please correct that everywhere.

screenshot from 2016-08-03 19 05 58

SaptakS commented 8 years ago

@mariobehling now the admin himself can set images for the placeholder as in #2016 . What are the things we need to do now in this issue? The only thing I recon is we need to add pictures for subcategories as well which I am doing. Anything else? Should I search for some better default placeholders as well or leave it to the admin to upload his own?

mariobehling commented 8 years ago

Yes, thank you. Only find a few more images for the subcategories. No need to find more suitable images. We can ask others to do this. It is simple.

SaptakS commented 8 years ago

Yes. @mariobehling we can even keep this as a GCI task I guess.

mariobehling commented 8 years ago

Thank you. So, please implement the structure and add some images. They can be changed later.

SaptakS commented 8 years ago

Yes. Working on it.

SaptakS commented 7 years ago

@mariobehling this is supposed to be a GCI task. The structure is already implemented. And we discussed that more images for the sub categories can be added by GCI participants. So I think we shouldn't be adding beta-release. What do you think?

mariobehling commented 7 years ago

Yes, correct. Could you make a list of the images needed, please? Which size is the standard size?

SaptakS commented 7 years ago

I will do that. What I wanted to know is is this feature necessary for release?? Because since this is a gci task, I am guessing it wont be completed before December. And we are targeting release in November. So I thought maybe beta-release label is not appropriate.

PolBaladas commented 7 years ago

Hi there! I've got a little nice image scraping script (scrapes pixabay). Would it be interesting to automatically get the pics that are needed? @mariobehling

PolBaladas commented 7 years ago

That'd be much faster

SaptakS commented 7 years ago

@PolBaladas we actually don't need all images but a single image for each subcategory which is just the default image. It is later completely customisable and the one hosting the server or anyone with admin level access can change it later. So I don't think you need scraping as such.You need to checkout the sub-categories and find images accordingly.

PolBaladas commented 7 years ago

Yeah, okay. I meant that if someone used the script it would be a faster method to get the pics, for exampe using a list with subcategories and taking the first pic each time.

Anyway, I get it now, Thanks! @SaptakS.

SaptakS commented 7 years ago

Well first pic might not always be the best one. Otherwise I do agree with your approach

PolBaladas commented 7 years ago

Okay then. We could maybe pick first 5 pics and select from there? I don't know if this would be impractical or not. Thanks

1- How many categories are there?

2 - What do you think @mariobehling ?

mariobehling commented 7 years ago

Please let's keep it simple. Discussion on this issue is already very long.

PolBaladas commented 7 years ago

Okay.

PolBaladas commented 7 years ago

Do we have a list of images that need to be uploaded? @SaptakS

niranjan94 commented 7 years ago

@PolBaladas yes. You can see the topics and subtopics at app/helpers/static.py

PolBaladas commented 7 years ago

Great! Thanks @niranjan94

PolBaladas commented 7 years ago

What about 133KB (or 272KB) for images and 25KB for thumbnails? @niranjan94 @mariobehling

SaptakS commented 7 years ago

25KB for thumbnails

@PolBaladas you don't need to save separately the thumbnails. When you upload the image, it automatically gets saved in 3 size formats - thumbnail, logo and icon

What about 133KB (or 272KB) for images

I think it is cool. But still check once to see whether the resolution is poor. If so you can try something with better resolution

PolBaladas commented 7 years ago

But this is for placeholder images, The ones we define not the ones the user will upload. So we still need to include thumbnails, right?

I think it is cool. But still check once to see whether the resolution is poor. If so you can try something with better resolution

Sure, will do.

PolBaladas commented 7 years ago

Sorry, couldn't resist to scrape it. I've got a script downloading all required images (reads from /app/helpers/static.py) @SaptakS. Downloading 4 imgs/topic from pexels. 100% license free. Gonna select the best by hand 👍

abishekvashok commented 7 years ago

This issue is looming large, can I go for a complete fix pls.

SaptakS commented 7 years ago

can I go for a complete fix pls.

What do you have in mind?

niranjan94 commented 7 years ago

I think we already have a set of good pictures given by @PolBaladas in #2648. That covers the scope of this ticket. Anything more could be dealt with in a new ticket. So closing this for now.

@Abhi2424shek if you wish to contribute alternative images please do go ahead with a PR referencing this issue (even if it is closed). Would love to have more contributions :smile: