fix-9000: Non-latin characters of names not rendered in ticket and order PDF

fossasia / open-event-server

The Open Event Organizer Server to Manage Events https://test-api.eventyay.com

https://api.eventyay.com

GNU General Public License v3.0

2.97k stars 1.89k forks source link

fix-9000: Non-latin characters of names not rendered in ticket and order PDF #9058

Closed ghost closed 1 year ago

ghost commented 1 year ago

Fixes: #9000

Short description of what this resolves:

Non-latin characters of names not rendered in ticket and order PDF

Changes proposed in this pull request:

Non-latin characters of names not rendered in ticket and order PDF

Checklist

[x] I have read the Contribution & Best practices Guide and my PR follows them.
[x] My branch is up-to-date with the Upstream development branch.
[ ] The unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] All the functions created/modified in this PR contain relevant docstrings.

ghost commented 1 year ago

hi @cweitat , @mariobehling , @norbusan please take a look on the Dockerfile for fixing issue.

norbusan commented 1 year ago

@lthanhhieu Can you please merge the RUN calls, as mentioned in my comment, thanks

norbusan commented 1 year ago

@lthanhhieu Do you have other suggestions concerning fonts? I fear that this PR only fixes Chinese names, but most probably not Japanese, Korean, Tamil, ...

ghost commented 1 year ago

@lthanhhieu Do you have other suggestions concerning fonts? I fear that this PR only fixes Chinese names, but most probably not Japanese, Korean, Tamil, ...

Thank @norbusan, I also added new font for other languages. As test in my local , now we can print with Chinese, Korean, Japaneses, Arabic, etc.

norbusan commented 1 year ago

@lthanhhieu that PR seems to be broken: The Docker image could not be build

17.12 ERROR: unable to select packages:
17.12   font-wqy-zenhei-0.9.45-r3:
17.12     masked in: @edge
17.12     breaks: world[wqy-zenhei=0.9.45-r2]

I will do the following changes:

remove all version numbers from the fonts (why did you add them @lthanhhieu ?)
remote wqy-zenhei and replace it with font-noto-cjk

Any comments?

norbusan commented 1 year ago

Additional comment: I tried the docker build locally, and it also failed. So did you actually try a docker build when you changed the Dockerfile?

ghost commented 1 year ago

Additional comment: I tried the docker build locally, and it also failed. So did you actually try a docker build when you changed the Dockerfile?

Thanks @norbusan , I try to build with --no-cache and found the same issue with you. Thank you for letting me know. I will try to remove and add the new font font-noto-cjk like you mentioned.

remove all version numbers from the fonts (why did you add them @lthanhhieu ?)

I have to add the version for all fonts due to the CI docker test: Please check the link following for more details https://app.deepsource.com/gh/fossasia/open-event-server/run/24360086-ee15-468e-9765-8b4b97cb9df7/docker/DOK-DL3018?listindex=0

norbusan commented 1 year ago

@lthanhhieu I have already merged a PR with the changes, so nothing needs to be done for now. I am aware of the docker deepsource remark, but I consider it bogus, we don't do it for the other packages either.