Add Internal Models For Notification Contents and Video Channels - Githubissues

fossasia / open-event-server

The Open Event Organizer Server to Manage Events https://test-api.eventyay.com

https://api.eventyay.com

GNU General Public License v3.0

2.96k stars 1.89k forks source link

Add Internal Models For Notification Contents and Video Channels #9116

Closed thealphadollar closed 8 months ago

thealphadollar commented 8 months ago

Fixes #

Short description of what this resolves:

Adds two internal models (not exposed via API).

Changes proposed in this pull request:

add: notification_contents internal model
add: video_channels internal model

Checklist

[x] I have read the Contribution & Best practices Guide and my PR follows them.
[x] My branch is up-to-date with the Upstream development branch.
[x] The unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)
[x] All the functions created/modified in this PR contain relevant docstrings.

norbusan commented 8 months ago

THanks, that looks nice, but I think it would be better if the introduction of the basic model is paired with the serializer, the views, and the URL definition, not to split all of it apart.

WDYT?