fossasia / open-event-wsgen

Open Event Website App Generator https://sched.eventyay.com
Apache License 2.0
2.01k stars 867 forks source link

Featured speakers and speakers should show up when session is accepted #2088

Open mariobehling opened 5 years ago

mariobehling commented 5 years ago

Featured speakers and the speakers page don't show speakers even though their session has been accepted (however not scheduled yet). They only show up when they are scheduled.

dhruvjain99 commented 3 years ago

Seems like this issue is resolved by looking into the codebase as this case is handled here in fold_v2.js file.

speakerid.forEach((speaker) => {
    if (speaker !== undefined) {
      speakerSessionDetail = sessionsMap.get(speaker.id);
      if (speakerSessionDetail === undefined) {
        return;
      }
      if (speakerSessionDetail.state === 'accepted' || speakerSessionDetail.state === 'confirmed') {
        sessiondetail.push({
          detail: speakerSessionDetail
        });
      }
    }
});

There is already a check to handle such a case. According to the above code, the speaker who has a session state as accepted is part of the speakerslist on the speakers page and featured section(if the speaker is featured) but it won't render/show speakers who are a part of speakers json and doesn't have any session. So according to me, this issue is already resolved. @mariobehling @iamareebjamal do let me know if I am missing anything and the issue is yet to be solved.

dhruvjain99 commented 3 years ago

If you want to display all the speakers irrespective of whether that speaker has a session or not, I'll do it but do let me know.