fossasia / open-event-wsgen

Open Event Website App Generator https://sched.eventyay.com
Apache License 2.0
2.01k stars 864 forks source link

let organiser chose his font #79

Closed championswimmer closed 8 years ago

championswimmer commented 8 years ago

Ideal case : Organiser should be able to set font in one place in config, and it gets changed everywhere

For now: Just extend the main css with coverage for all main classes and apply fonts on them. Changing fonts will have to work by Find&Replace All across the css.

creativepsyco commented 8 years ago

I think we probably need a simplified styling approach: fonts, colors, headings etc. all can be defined by a config file which can be injected into Sass etc during css generation & would make for a better approach. What do you think? Is it achievable? I kind of feel the styles on the website could use a little bit of uplift.

leto commented 8 years ago

:+1: to making the font configurable easily in a config file. Also we may want to look into including the iconic font Font-Awesome by default: https://fortawesome.github.io/Font-Awesome/icons/

creativepsyco commented 8 years ago

Sounds good :+1:

SaptakS commented 8 years ago

I would like to do this fix.

SaptakS commented 8 years ago

Should I generate a separate .css file from sass or should I change in the leaflet.css using sass?

creativepsyco commented 8 years ago

upto you, whichever you think is easier to implement and has more impact, you can imagine that one one organization can organize multiple events, so I would suppose that sass can help, using some variables etc.

SaptakS commented 8 years ago

Yeah I am doing in sass/scss for the purpose. I will read from the config.js the theme they want and then accordingly set the variables in sass. And then inject using gulp. Sounds ok?

creativepsyco commented 8 years ago

yep sounds okay.

championswimmer commented 8 years ago

@SaptakS leaflet.css is for the leaflet module. We are using main.css for our webapp. Do not modify any css we are importing from the modules.

SaptakS commented 8 years ago

I guess this issue has already been resolved during GCI. #89