search

fossasia / open-event

Open Event Project, Samples, Documentation and Artwork http://open-event-dev.herokuapp.com
GNU General Public License v3.0
1.71k stars 175 forks source link

fix: replaced all the conflicting attribute names in FOSSASIA16 sample #192

Closed arp95 closed 7 years ago

arp95 commented 7 years ago

fixes part of #190

all the conflicting attribute names with old api are removed in the fossasia16 sample.

@iamareebjamal @Shailesh351 @shreyasnbhat @rohanagarwal94 @Princu7 please review.

Princu7 commented 7 years ago

@arp95 Looks Nice. I guess it would be better if you could also give the link to the script which you used for changing the attributes present in the different files. It is difficult to look at all the changes at once. Looking at the script would be less time consuming and efficient I think.

I have incorporated the new recent attributes changes locally and the app generates fine on it. There are small problems (unrelated to the conflicting attributes) with some of the speakers as their images are not showing up. I think that there is a typo in their name like the previous few issues that we solved. Yes, it is unrelated but can you also please look at that too afterwards? Thanks :)

Princu7 commented 7 years ago

@arp95 This is the test server which supports the new attributes in the current API models. If you want, you can generate a web app using it. Thanks :) https://shrouded-ocean-89460.herokuapp.com

arp95 commented 7 years ago

so for the new attribites i will just add them as empty strings, wgile for changed attributes will update them. fine?

arp95 commented 7 years ago

the script link is https://github.com/arp95/script_for_samples please check this.

mariobehling commented 7 years ago

Merging this as work in progress. Thanks.