search

fossasia / phimpme-android

Phimp.me Photo Imaging and Picture Editor https://play.google.com/store/apps/details?id=org.fossasia.phimpme
GNU General Public License v3.0
2.58k stars 929 forks source link

Remove dependencies for F-droid #2907

Open codedsun opened 4 years ago

codedsun commented 4 years ago

Describe the bug There are maven dependencies which should be removed for F-droid inclusion

Would you like to work on the issue?

codedsun commented 4 years ago

@iamareebjamal I am removing the following dependencies of maven

        url "https://dl.bintray.com/dasar/maven"
    maven { url 'https://maven.fabric.io/public' }
    maven { url "https://mvnrepository.com/artifact/com.box/box-android-sdk" }

For box sdk do we need to create a flavors for the app or just remove this option from now?

Also I am facing issue in colorpickr which we have used in Paint Fragment and addText Fragment, what should be done?

codedsun commented 4 years ago

@iamareebjamal ?

iamareebjamal commented 4 years ago

@yashk2000

codedsun commented 4 years ago

@yashk2000 Please update on this

iamareebjamal commented 4 years ago

Also I am facing issue in colorpickr which we have used in Paint Fragment and addText Fragment, what should be done?

Tell the issue please, not just you are facing an issue

iamareebjamal commented 4 years ago

You don't need maven repo for box SDK. Next

codedsun commented 4 years ago

@yashk2000 @iamareebjamal while removing these above dependencies I m getting this error

ERROR: Failed to resolve: uz.shift:colorpicker:0.5
Show in Project Structure dialog
Affected Modules: app

What shall I do ?

iamareebjamal commented 4 years ago

Use a different color picker

codedsun commented 4 years ago

Okay thanks!

niccokunzmann commented 4 years ago

@codedsun as you worked on this, I think you can ping the developers in the F-Droid inclusion issue, so they know that they can check again.