set up venv to manage pslab-python dependency

fossasia / pslab-desktop

PSLab Desktop Application https://pslab.io

GNU General Public License v3.0

1.77k stars 364 forks source link

set up venv to manage pslab-python dependency #638

Closed orangecms closed 3 years ago

orangecms commented 3 years ago

Currently, the desktop app is importing PSL (https://github.com/fossasia/pslab-python) from the system (or PYTHONPATH, that is). For full-stack development and production builds, it would be nice to encapsulate the environment. Python 3 has added native support for environments through venv. Implement venv for the desktop app.

asha15 commented 3 years ago

Shall i work on this?

orangecms commented 3 years ago

The choice is yours - just file a PR, please. Thank you!

cynthi8 commented 3 years ago

How could we create a venv that works for all production builds? When we package the binaries the packaged application will use the venv for our computer, but when someone else downloads that binary, the packaged venv might not point to the right python executable location.