fossasia / pslab-hardware

PSLab Hardware Design and Schematics https://pslab.io
Apache License 2.0
1.64k stars 92 forks source link

Added SMD Crystal replacing TH Oscillator #10

Closed CloudyPadmal closed 7 years ago

CloudyPadmal commented 7 years ago

@jithinbp I've created a copy of the project with the name PSLab_OSC and added the FOX924B Oscillators. Put it to the top layer as the PIC and routed. Can you please review if it's correct? :) Thanks a lot!!

jithinbp commented 7 years ago

Hi @CloudyPadmal I checked out your changed by cloning into your fork . Connections look good . :) However, I think it can't be merged because you have edited the main project schematic itself instead of a separate copy.

A couple of other points:

CloudyPadmal commented 7 years ago

Hello @jithinbp Ah it seems I haven't created the copy correctly! I'll fix it and send a PR soon! Is it okay if I copy the content to a new folder and make edits there? KiCAD doesn't have a way to save as it seems!!

CloudyPadmal commented 7 years ago

And for the MCP2200 OSC, should I connect the same oscillator or should I add another one?

jithinbp commented 7 years ago

If you're making a separate copy, I think we can call it something that indicates it has higher precision. Analog reference can also be a higher precision one here. Maybe we should consult @mario first. But it might be painful to keep all the other hardware changes synced in both directories.

As for separate crystal, I don't think it's necessary now. 12mhz is priced the same as 25mhz on Mouser.

On 12 May 2017 9:39 p.m., "Padmal" notifications@github.com wrote:

And for the MCP2200 OSC, should I connect the same oscillator or should I add another one?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fossasia/pslab-hardware/pull/10#issuecomment-301119028, or mute the thread https://github.com/notifications/unsubscribe-auth/AFzAwlBLtId_SZ7ieMPzItS1CD3tePTUks5r5IRBgaJpZM4NYHEo .

CloudyPadmal commented 7 years ago

It's a different user tagged by mistake! @mariobehling !