fossasia / pslab-hardware

PSLab Hardware Design and Schematics https://pslab.io
Apache License 2.0
1.64k stars 92 forks source link

Added SMD Crystal replacing through hole Oscillator #12

Closed CloudyPadmal closed 7 years ago

CloudyPadmal commented 7 years ago

Replaced the TH Oscillator with FOX924B SMD crystal and routed paths to PIC and MCP2200 ICs

CloudyPadmal commented 7 years ago

Hello @jithinbp ! I will look into the layout and make those changes to update the PR! 😊 Thank you for the support! Inspecting KiCAD files from command line is it easier?

jithinbp commented 7 years ago

Hi @CloudyPadmal , I just checked the latest commit , but the 15pF footprint is still present in the layout. am I correct? You should also reference the relevant issue in your commit messages. in this case we have not raised one yet. thanks

CloudyPadmal commented 7 years ago

Hello @jithinbp ! I removed the capacitor in the last commit and now layout is like this! :thinking:

screenshot from 2017-06-06 15-22-43

jithinbp commented 7 years ago

psl_15pf This is what it looks like for me.

I did the following to fetch the contents: git checkout -b CloudyPadmal-replaceOSC master git pull https://github.com/CloudyPadmal/pslab-hardware.git replaceOSC

Today I simply ran the second command again. about four or five files including the layout had changes, but the 15pF is still there

From https://github.com/CloudyPadmal/pslab-hardware
 * branch            replaceOSC -> FETCH_HEAD
Removing PSLab KiCAD v2/_saved_PSLab.sch
Merge made by the 'recursive' strategy.
 PSLab KiCAD v2/IO.bak              |  136 ++--
 PSLab KiCAD v2/IO.sch              |  136 ++--
 PSLab KiCAD v2/PSLab.bak           |  255 ++++---
 PSLab KiCAD v2/PSLab.kicad_pcb     | 1183 +++++++++++++++---------------
 PSLab KiCAD v2/PSLab.kicad_pcb-bak | 3380 +++++++++++++++++++++++++++++++++++++++++++-------------------------------------------
 PSLab KiCAD v2/PSLab.net           |  874 +++++++++++-----------
 PSLab KiCAD v2/PSLab.sch           |  304 ++++----
 PSLab KiCAD v2/_saved_PSLab.sch    | 2263 ---------------------------------------------------------
 8 files changed, 3095 insertions(+), 5436 deletions(-)
 delete mode 100644 PSLab KiCAD v2/_saved_PSLab.sch

please add the following to .gitignore, and untrack the files also. thanks

# For PCBs designed using KiCad: http://www.kicad-pcb.org/

# Temporary files
*.000
*.bak
*.bck
*.kicad_pcb-bak
*~
_autosave-*
*.tmp

# Netlist files (exported from Eeschema)
*.net

# Autorouter files (exported from Pcbnew)
*.dsn
*.ses

# Exported BOM files
*.xml
*.csv
CloudyPadmal commented 7 years ago

I've added the .gitignore and edited the track connecting OSC. Can you give it a look now? :blush:

jithinbp commented 7 years ago

All good :)

CloudyPadmal commented 7 years ago

Thanks alot @jithinbp ! :blush: :100: :+1: