search

fossasia / pslab-hardware

PSLab Hardware Design and Schematics https://pslab.io
Apache License 2.0
1.64k stars 92 forks source link

Replace Power Supply #14

Closed CloudyPadmal closed 6 years ago

CloudyPadmal commented 7 years ago

Hello @jithinbp ! I've made the changes accordingly to the new power supply. :)

+VE Simulation -VE Simulation
+ve -ve

screenshot from 2017-05-20 06-33-54

CloudyPadmal commented 7 years ago

Hello @jithinbp ! That's a great review and thanks for that! :blush:

I have made the change in a separate branch. I think git clone https://github.com/CloudyPadmal/pslab-hardware.git --branch pwrSupply --single-branch <folder> might clone it right hopefully?

jithinbp commented 7 years ago

happy to help! 6mA and +/-6V should work, so a 6v8 zener can be used. You'll end up with around 5.9V from what I've seen.

I'm having trouble with checking out the pslab-firmware PR into a branch. I believe I will have to clone your fork for that one also. The .gitignore seems to have been deleted. Mine looks like this: /MPLABProject/nbproject/private/ /MPLABProject/build/default/ /MPLABProject/dist/default/ /PSLab_Original/dist/default/ /PSLab_Original/build/default/

These files are changed by the IDE, and it seems the IDE added those automatically as I don't recall doing so.

On Fri, Jun 2, 2017 at 5:10 PM, Padmal notifications@github.com wrote:

Hello @jithinbp https://github.com/jithinbp ! That's a great review and thanks for that! 😊

  • I will change the R11 to 1K. It's a mistake!
  • About the current, so can I use 1.5 mA x 4 = 6 mA in the simulation?
  • And the supply voltage at +/-6V?

I have made the change in a separate branch. I think git clone https://github.com/CloudyPadmal/pslab-hardware.git --branch pwrSupply --single-branch might clone it right hopefully?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fossasia/pslab-hardware/pull/14#issuecomment-305763161, or mute the thread https://github.com/notifications/unsubscribe-auth/AFzAwnRZxbKZY--4QIbn_8813I_p7Kwoks5r__SwgaJpZM4NhJwI .

-- jithin

CloudyPadmal commented 7 years ago

Thanks again @jithinbp ! Here's a screenshot of the .gitignore in my pc repo: screenshot from 2017-06-02 17-40-08 Is it deleted in the PR?

CloudyPadmal commented 7 years ago

And @jithinbp can I make this power supply module in a hierarchical block? :blush:

jithinbp commented 7 years ago

@CloudyPadmal since the schematic isn't very dense at the moment, I don't feel we need to split it into small fragments. It's a lot easier to understand the schematic if most of the critical parts are in one place. It's a personal view though, and the power supply can certainly be moved to a separate page if the clutter is too high.

CloudyPadmal commented 7 years ago

Agreed to that @jithinbp ! Let's keep the schematic as this is for now and move to blocks when it is too compacted later! :+1:

jithinbp commented 7 years ago

Hi, I've gone through the schematic changes you've made. It looks functionally correct, but DRC checks are failing. Could you please clear the errors in 'electrical rules check' ? there's a button on the eschema toolbar that looks like this : drc

Also, are you planning to incorporate the corresponding layout changes in a separate issue? If so, please mention that this issue only deals with the schematic thanks :)

CloudyPadmal commented 7 years ago

Hello @jithinbp ! I will check the electric rule check and fix the issues there! I think it's better to create a new issue to layout implementation right? 😊 I will open one! Thanks for the help! 🥇

CloudyPadmal commented 6 years ago

Changes made in the #22 . Hence closing!