search

fossasia / pslab-hardware

PSLab Hardware Design and Schematics https://pslab.io
Apache License 2.0
1.64k stars 92 forks source link

Use kibot to generate diffs #147

Closed CloudyPadmal closed 8 months ago

CloudyPadmal commented 8 months ago

Instead of terminal based diff images, now kibot has an option called 'diff' that generate diff pdfs between schematics and PCBs. (https://github.com/INTI-CMNB/KiBot)

We may use that for reviewing changes.

CloudyPadmal commented 8 months ago

~Fixes in #146~

bessman commented 8 months ago

Cool!

How does one read the diffs? At a glance, the diff_schematic.pdf looks identical to PSLab.pdf, just in black-and-white.

CloudyPadmal commented 8 months ago

Something is not right with the diff configuration in CI.kibot.yaml. The PDF should look like this: diff_schematic.pdf with red and green stuff

CloudyPadmal commented 8 months ago

Now it works! 🚀