fossasia / pslab-python

Python Library for PSLab Desktop: https://pslab.io
GNU General Public License v3.0
1.62k stars 226 forks source link

Handle conflict in namespace 'serial' #114

Closed bessman closed 4 years ago

bessman commented 4 years ago

The packages 'pyserial' and 'serial' both use the 'serial' namespace. Therefore, import serial will succeed if the user has the latter package installed, even though PSL needs the former. This results in an unhelpful "Could not connect" RuntimeError down the line.

With this change, PSL verifies that the correct 'serial' was imported, and complains otherwise.