search

fossasia / pslab-python

Python Library for PSLab Desktop: https://pslab.io
GNU General Public License v3.0
1.62k stars 226 forks source link

Add unit tests #116

Closed bessman closed 3 years ago

bessman commented 4 years ago

PSL lacks unit tests. I'm interested in writing them, if you think they would be useful to the project.

Add unit tests for SENSORS

mariobehling commented 4 years ago

This would be great. We would also like to invite you to our weekly meeting at 5 pm CET on Saturdays to discuss details and find out how we could involve you more. Please join the call here https://meet.jit.si/fossasia-hw

bessman commented 4 years ago

Thanks for the invite! I might not be able to join tomorrow though. If not, I'll join next week.

BHAKTA-VARUN commented 3 years ago

hi everyone, can i work with you guys I am a beginner here. you can assign me any task

bessman commented 3 years ago

Hi @BHAKTA-VARUN, tests are being added as part of the ongoing refactorization effort: #127. Unfortunately it is not really beginner friendly.

Do you have a PSLab device?

BHAKTA-VARUN commented 3 years ago

no sir i don't have PSLab device

but thank you very much for showing concern. If in any way i can help you please let me know. I learnt python and mysql. If you require those skills please let me know.

Finally, please suggest any thing which I can learn to be able to contribute.

thank you

On Sun, Nov 1, 2020 at 12:57 AM Alexander Bessman notifications@github.com wrote:

Hi @BHAKTA-VARUN https://github.com/BHAKTA-VARUN, tests are being added as part of the ongoing refactorization effort: #127 https://github.com/fossasia/pslab-python/issues/127. Unfortunately it is not really beginner friendly.

Do you have a PSLab device?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fossasia/pslab-python/issues/116#issuecomment-719977022, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARJ5KU7GQR4GKLP7VVB6ZBTSNRQI5ANCNFSM4NRRYGSQ .

bessman commented 3 years ago

Closing this since most built-in instruments now have tests.

viric commented 3 years ago

Is it possible that tests for 'external' fail today? It seems there is outdated code. How do you run the tests currently?

bessman commented 3 years ago

Tests are run with tox -e playback (using recorded serial traffic, requires no hardware) or tox -e integration (requires hardware). There are only a few tests for external right now, because as you noticed most of that code is outdated. The tests that do exist are passing.