Update pin names - Githubissues

fossasia / pslab-python

Python Library for PSLab Desktop: https://pslab.io

GNU General Public License v3.0

1.62k stars 226 forks source link

Update pin names #140

Closed bessman closed 3 years ago

bessman commented 3 years ago

Change all instances of

ID1/2/3/4 -> LA1/2/3/4
SEN -> RES
AN8 -> VOL
CNTR -> FRQ
W1/2 -> SI1/2

Nanak360 commented 3 years ago

I would like to work on it. It will be very helpful if I could get a little more information. Screenshot (275) Screenshot (276)

I see many instances of ID1, ID2, SEN Should I change them all in each and every file?

bessman commented 3 years ago

Thanks! Yes, that's right. Every instance in every file.

Nanak360 commented 3 years ago

All right, I'll work on it. Would you please assign me? I would also like to know if this contribution will be a part of Hacktoberfest.

bessman commented 3 years ago

Sure, we can opt in and tag your pull request as hacktoberfest-approved.

Nanak360 commented 3 years ago

@bessman I have changed each and every instance from all the files and created a pull request. Please guide me through, what do I do now for the Hacktoberfest part.

bessman commented 3 years ago

Fixed by #141.