search

fossasia / pslab-python

Python Library for PSLab Desktop: https://pslab.io
GNU General Public License v3.0
1.63k stars 225 forks source link

Fixed pslab cli entry point #169

Closed nkpro2000sr closed 3 years ago

nkpro2000sr commented 3 years ago
  1. Fixed pslab cli entry point, according to PSL -> pslab commit.
  2. Fixed incorrect timestamps in pslab.cli.oscilloscope. which previously return repeated timestamps instead of continues.
bessman commented 3 years ago

Good catch on the entry point.

As for the timestamps, I think the current behavior is correct. I imagine that the typical use case for the cli tools is to pipe the output somewhere, like gnuplot. In that case, the used would expect the output from the oscilloscope instrument to look like it comes from an oscilloscope, which does not increment timestamps in this manner but rather repeats them for each measurement period.