search

fossasia / pslab-python

Python Library for PSLab Desktop: https://pslab.io
GNU General Public License v3.0
1.63k stars 226 forks source link

Fix for issue #171 #176

Closed EricLiclair closed 3 years ago

EricLiclair commented 3 years ago

Am not sure about the variable 'gain', but I had a look at the line number 371 and implemented the necessary changes as mentioned in this comment https://github.com/fossasia/pslab-python/issues/171#issuecomment-787070650

I noticed a gap in the comments and thought if there might be some reason the issues is not solved yet.

Also, I do not have a PSLab device to record new serial traffic. Further help needed.

bessman commented 3 years ago

Thank you, your fix has been merged :smile: Since I had to record some serial traffic, I have merged your branch outside of this pull request. This pull request will therefore be closed.