search

fossasia / pslab-python

Python Library for PSLab Desktop: https://pslab.io
GNU General Public License v3.0
1.63k stars 225 forks source link

Add driver for eCO2 and eTVOC sensor CCS811 #215

Closed RafaelLeeImg closed 1 year ago

RafaelLeeImg commented 1 year ago

pipeline failed: tox -e lint

lint: tox-gh-actions couldn't understand the parallel option. ignoring the given option: 0 tox: lint lint: commands[0]> black --check pslab/bus/ pslab/instrument/ pslab/serial_handler.py pslab/cli.py pslab/external/motor.py pslab/external/gas_sensor.py pslab/external/hcsr04.py would reformat /home/runner/work/pslab-python/pslab-python/pslab/bus/spi.py

bessman commented 1 year ago

pipeline failed: tox -e lint

Fixed, please rebase.

bessman commented 1 year ago

You can leave spi.py unchanged, I fixed it in https://github.com/fossasia/pslab-python/commit/8778361c9355f11374579064ea7f8b01ce92b496.

Also, please add this file to the linter whitelist at https://github.com/fossasia/pslab-python/blob/222a798ebfbf8acd7f5951b8f06a09860c4bb870/tox.ini#L24.

RafaelLeeImg commented 1 year ago

Is there anything more I need to fix?

bessman commented 1 year ago
  1. Revert changes to spi.py.
  2. Add ccs811.py to linter whitelist here: https://github.com/fossasia/pslab-python/blob/222a798ebfbf8acd7f5951b8f06a09860c4bb870/tox.ini#L24
  3. Address any linter warnings that appear after whitelisting.